Trend reports are based on distribution/donation/purchase issued date #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed/purchased items over the past year
dorner
requested changes
Nov 16, 2024
dorner
approved these changes
Nov 21, 2024
|
Looks good, thanks! |
|
@jp524: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4738
Description
There was a difference between the data shown on the Distributions page and the Distributions Trend Report. The Distribution page was showing quantities per distribution's issued date, while the Trend Report page was showing quantities per line item's creation date.
The trend report uses
HistorialTrendServiceto build the data that will be displayed. Modifying this service also fixed trend reports for donations and purchases.Type of change
How Has This Been Tested?
Modified and added tests to
HistoricalTrendService.Also visually confirmed results by comparing trend report to filtered data (refer to screenshots below).
Screenshots
Distribution trend report from before:
After: